About Thread Long Runs

[MrLi2018]

If a thread continuously executes different scripts for a long time, the memory usage will be exceeded. This is because the CPU execution time is the total time of the thread.

[mxro]

Thank you for raising this issue! What do you think could be a good solution to this?

I guess a workaround would be to spawn new threads? And otherwise probably calculate execution time delta?

[MrLi2018]

Thanks for your answer, I'm not sure if the problem exists or if I'm using it incorrectly, I've tried to use new threads, but this will increase my thread context switching.

[mxro]

Looking at this line in the code: https://github.com/javadelight/delight-nashorn-sandbox/blob/master/src/main/java/delight/nashornsandbox/internal/ThreadMonitor.java#L123 It seems as if the starttime is taken into consideration when calculating if the runtime for a particular thread is exceeded.

So it shouldn't be required to create a new thread solely for the purpose to have the cpu limit work. That being said, I think getThreadCpuTime may not be very accurate: https://github.com/javadelight/delight-nashorn-sandbox/blob/master/src/main/java/delight/nashornsandbox/internal/ThreadMonitor.java#L216

[tellmewhattodo]

This sandbox implementation use two parallel running thread to control resource usage (memory, cpu). As one thread run the script, the other looping itself to check if resource usage is exceed(by MX bean, which is not strictly accurate). The looping thread waits until script ends or resources limit reached. I think these information might be helpful. 2022年1月28日 17:30，MrLi2018 ***@***.******@***.***>> 写道： Thanks for your answer, I'm not sure if the problem exists or if I'm using it incorrectly, I've tried to use new threads, but this will increase my thread context switching. — Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjavadelight%2Fdelight-nashorn-sandbox%2Fissues%2F123%23issuecomment-1024037389&data=04%7C01%7C%7C981a255ced8a4bc46b8208d9e240db92%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637789590466306395%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=L0pm60AgseY5eD%2BBEjFLVBlA%2B1XTFGMaQRYpCI46MWg%3D&reserved=0>, or unsubscribe<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAI7K2BMK5QOFI2RBRTATPBLUYJO4HANCNFSM5M2HP6NA&data=04%7C01%7C%7C981a255ced8a4bc46b8208d9e240db92%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637789590466306395%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=IwwMD5nSIAHB4mYcJzhMyAti0D1SojYN57ZkWLxIS8w%3D&reserved=0>. Triage notifications on the go with GitHub Mobile for iOS<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7C981a255ced8a4bc46b8208d9e240db92%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637789590466306395%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=qD8B6K0M7SffRHUKfzfJnDMWjd0%2FE%2FA425o%2BWGX%2BxCo%3D&reserved=0> or Android<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7C981a255ced8a4bc46b8208d9e240db92%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637789590466306395%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=BK5W%2FNX18SsaB5%2Bt6ybmQTpk4gmnuTuf2FZPyl44i3M%3D&reserved=0>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[MrLi2018]

I have a question about whether the rhino scripting engine can set thresholds for instruction counts and whether nashorn can do the same without relying on thread monitoring.