New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the beautifyjs function make script invoke timeout #120
Comments
Thank you for raising this issue! Is the problem you encounter that when a script contains multiline comments that the processing time for the script increases? Could you provide an example for a script? Would it be possible to remove comments from the script before running it? |
the multiline //:\n comment canceled will be increase the script invoked tps; "Would it be possible to remove comments from the script before running it?"——sometimes addtional funtions may be commented for use in future ! |
@hlzhang123 Thank you for providing the sample code. I have created a new branch and put some of the code into there: https://github.com/javadelight/delight-nashorn-sandbox/compare/issue-120?expand=1 Could you expand on the unit test I put there to show the problem? Btw, the sandbox generates the following code from the one provided:
So it looks like the comments are not removed as they should according to this class: https://github.com/javadelight/delight-nashorn-sandbox/blob/master/src/main/java/delight/nashornsandbox/internal/RemoveComments.java ? |
we find when the script contains multiline comments were invoke by scriptEngine, before invoked,the beautify funtion decrease the tps
The text was updated successfully, but these errors were encountered: