Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor edits to run code in Python 3 from volatility directory #7

Open
JohnSchwitz opened this issue Oct 21, 2017 · 1 comment
Open
Assignees

Comments

@JohnSchwitz
Copy link

JohnSchwitz commented Oct 21, 2017

volest.py changed to: import models. It was: from volatility import models
models init.py changed to: from models.api import *

data is in tests directory thus: data_file_path = '../tests/JPM.csv'

I would add 2 explicit lines after vol. I needed to reference fig, plt not just plt.
fig, plt = vol.cones(windows=windows, quantiles=quantiles)
plt.show()

I could not get vol.term_sheet to work.

@JohnSchwitz JohnSchwitz changed the title Minor edits to run code in Python 3 form volatility directory Minor edits to run code in Python 3 from volatility directory Oct 21, 2017
@jasonstrimpel jasonstrimpel self-assigned this Nov 22, 2017
@jasonstrimpel
Copy link
Owner

Can't quite tell if these are suggestions to make compatible with Py3 or these are changes you've made. As far as the term_sheet goes, you need to ensure you define a benchmark for the regressions (included in term sheet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants