Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to pass in trading periods #29

Open
bgits opened this issue Feb 17, 2023 · 0 comments
Open

Unable to pass in trading periods #29

bgits opened this issue Feb 17, 2023 · 0 comments

Comments

@bgits
Copy link

bgits commented Feb 17, 2023

Every estimator can accept a parameter trading_periods (probably should be named annual_trading_days), however when calling it in on the of the VolatilityEstimator methods, there is no way to pass that parameter through. This will cause issues for markets such as FX, crypto and basically anything other than U.S. Equities.

Simple solution is to allow it to be passed through as an option parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant