Skip to content
This repository has been archived by the owner on Dec 9, 2018. It is now read-only.

Fails to build with the new allocator system #153

Open
zkbpkp opened this issue Aug 31, 2017 · 3 comments
Open

Fails to build with the new allocator system #153

zkbpkp opened this issue Aug 31, 2017 · 3 comments

Comments

@zkbpkp
Copy link

zkbpkp commented Aug 31, 2017

xargo build throws an error while compiling ralloc dependency:

   Compiling ralloc v1.0.0 (https://github.com/redox-os/ralloc#a93871cd)
error[E0557]: feature has been removed
  --> /home/boss/.cargo/git/checkouts/ralloc-797ee1a3f928155b/a93871c/src/lib.rs:18:12
   |
18 | #![feature(allocator, const_fn, core_intrinsics, stmt_expr_attributes, drop_types_in_const,
   |            ^^^^^^^^^

error: The attribute `allocator` is currently unknown to the compiler and may have meaning added to it in the future (see issue #29642)
  --> /home/boss/.cargo/git/checkouts/ralloc-797ee1a3f928155b/a93871c/src/lib.rs:12:36
   |
12 | #![cfg_attr(feature = "allocator", allocator)]
   |                                    ^^^^^^^^^^
   |
   = help: add #![feature(custom_attribute)] to the crate attributes to enable

error: aborting due to 2 previous errors

error: Could not compile `ralloc`.

Related issue: https://github.com/redox-os/ralloc/issues/56

@japaric
Copy link
Owner

japaric commented Sep 9, 2017

naive_ralloc, our in-tree dumb allocator, has been updated to work with the new allocator system so you can use that until ralloc is updated. To do that compile steed with default-features = false and features = ["naive_ralloc"].

@japaric
Copy link
Owner

japaric commented Sep 9, 2017

compile steed with default-features = false and features = ["naive_ralloc"].

Add those two lines to the Xargo.toml you are using, under the [dependencies.std] header

dvc94ch added a commit to dvc94ch/steed that referenced this issue Nov 12, 2017
The allocator feature was removed in ralloc commit
cd8d627ecd5eb633833fe9fb8973219c2101ff61.

Closes japaric#153.
@radix
Copy link

radix commented Feb 22, 2018

It seems that the dependency on ralloc is not pinned to a specific revision. Shouldn't it be?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants