Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Search? #183

Open
hoffi opened this issue Jan 21, 2015 · 12 comments
Open

Global Search? #183

hoffi opened this issue Jan 21, 2015 · 12 comments
Labels

Comments

@hoffi
Copy link
Collaborator

hoffi commented Jan 21, 2015

I always like to have an "app-wide" search, which searches just everywhere it can and displays the results categorized by the containing app for example.

Not very easy to implement but what do you think?

@hoffi hoffi added the question label Jan 21, 2015
@johnpool3
Copy link

This sounds like a great idea, a bit like spotlight on a mac perhaps.

@Jon889
Copy link
Collaborator

Jon889 commented Jan 22, 2015

I started implementing this a few days ago, and it works, just knowing how to display the results is a bit ugly, I'm passing the name of the directive (view) in the list of apps (model). I've pushed the branch, there's a lot I'm unsure on the best way to implement, but I tried to do it in a way that keeps things seperate and modular.

@jansmolders86
Copy link
Owner

This is awesome guys! I have a couple of thoughts on the visual implementation. Do you mind me weighing in on this as well? I don't want to step on your feature if you just want to complete it yourself!

@Jon889
Copy link
Collaborator

Jon889 commented Jan 22, 2015

Definitely! I don't know about the others, but I guess it's the same, but I don't consider anything "my" feature :)

@jansmolders86
Copy link
Owner

Excellent. I just don't want to step on anyone's toes here. I fully appreciate all the hard work you guys are doing!

@hoffi
Copy link
Collaborator Author

hoffi commented Jan 26, 2015

Hey @Jon889
really like it already 👍

But i would find it more useful if the search is directly on the "dashboard".

@Jon889
Copy link
Collaborator

Jon889 commented Jan 26, 2015

I quite agree :) though it seemed like that would be easier to do after making it a single page app (which is necessary to do things like background audio, or shrinking the video player picture in picture style)

@jansmolders86
Copy link
Owner

Sorry I've taken so long to respond guys! I've been work pretty much day and night for the last couple of weeks. It'll soon get less busy and when it does I want to prioritize making MCJS a complete onepage angular app which ties in nicely with this issue as Jon mentioned!

@Jon889
Copy link
Collaborator

Jon889 commented Jan 29, 2015

Work should definitely be the priority, though hopefully you don't work yourself to death :) I'm curious what you ideas were for the search?

@jansmolders86
Copy link
Owner

Thanks for understanding. I just don't want you guys to get the feeling I'm abandoning this project. :)

I want to express again I totally love this feature! It's really well done already! And super fast!
I just have a ton of ideas to use this once we have the entire thing in Angular.

I would love to see a Windows 8+ esk search capability that would really fit the project!
I'll open an issue for the anugalrisation of the entire projects to discuss it's features.

@jansmolders86
Copy link
Owner

So @Jon889 @hoffi , shall we merge this in it's current state? I love the current functionality already and I hate to see us waist this work until we move to the 2.0 version.

@Jon889
Copy link
Collaborator

Jon889 commented Feb 4, 2015

There are some parts of the implementation I'm not quite happy with, there isn;t really a way to search multiple types of things from the same app (for example tracks and albums in the music app). And the way it knows what directive to use to display the results is odd/too connected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants