Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default entry points #42

Open
jankapunkt opened this issue Oct 4, 2023 · 0 comments
Open

Fix default entry points #42

jankapunkt opened this issue Oct 4, 2023 · 0 comments
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@jankapunkt
Copy link
Owner

jankapunkt commented Oct 4, 2023

Describe the bug

The default entry points are not 100% working in all environments plus some popular ones are missing

To Reproduce
Import a package using recent vite build system

Expected behavior
should import

Additional context

It should be the following:

{
  "type": "module",
  "main": "dist/index.cjs.js",
  "browser": "dist/index.iife.js",
  "exports": {
    "import": "./dist/index.js",
    "require": "./dist/index.cjs.js"
  },
  "module": "dist/index.js",
  "unpkg": "dist/index.iife.js",
  "jsdelivr": "dist/index.iife.js",
  "types": "dist/index.d.ts",
}

Note that types are missing, too and require #41 to be implemented

@jankapunkt jankapunkt added enhancement New feature or request good first issue Good for newcomers dependencies Pull requests that update a dependency file hacktoberfest labels Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

1 participant