Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SDL window resizable and optionally fullscreen #23

Open
jankammerath opened this issue Jan 30, 2017 · 1 comment
Open

Make SDL window resizable and optionally fullscreen #23

jankammerath opened this issue Jan 30, 2017 · 1 comment
Assignees

Comments

@jankammerath
Copy link
Owner

F key should make it go fullscreen and in window mode the window should be resizable.

@jankammerath jankammerath added this to the alpha 0.3 milestone Jan 30, 2017
@jankammerath jankammerath self-assigned this Jan 30, 2017
@jankammerath jankammerath changed the title Make SDL window resizable and optinally fullscreen Make SDL window resizable and optionally fullscreen Jan 30, 2017
@jankammerath jankammerath removed this from the alpha 0.3 milestone Jan 30, 2017
@jankammerath
Copy link
Owner Author

I implemented fullscreen toggle. In the SDL documentation it describes how to define a window as resizable: https://www.libsdl.org/release/SDL-1.2.15/docs/html/sdlsetvideomode.html

The problem however with the SDL_RESIZABLE flag is that it signals the resize event which then requires all elements (LibVLC, WebKit2Gtk and SDL) to resize theirselves. Also patched issues where the dimensions defined in config were not considered by WebKit.

However all of this work does not reflect the initial ticket purpose, so I removed the milestone tag and will keep it for a later version. Beta 0.7 or even 1.0 would be suitable as this at the moment is nice to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant