Empty additionalProperties object is generated as an array #700
Comments
|
In janephp if (null !== $object->getExposedPorts()) {
$values = new \stdClass();
foreach ($object->getExposedPorts() as $key => $value) {
$values->{$key} = $value;
}
$data->{'ExposedPorts'} = $values;
}Is this a regression? |
|
So it looks like janephp has moved away from using We probably need to check if the object is empty and return |
|
This works, but would mean a check on every object: if ($object->isInitialized('exposedPorts') && null !== $object->getExposedPorts()) {
$values_3 = [];
foreach ($object->getExposedPorts() as $key => $value_3) {
$values_4 = [];
foreach ($value_3 as $key_1 => $value_4) {
$values_4[$key_1] = $value_4;
}
if (count($values_4) === 0) {
$values_4 = new \ArrayObject(array(), \ArrayObject::ARRAY_AS_PROPS);
}
$values_3[$key] = $values_4;
}
if (count($values_3) === 0) {
$values_3 = new \ArrayObject(array(), \ArrayObject::ARRAY_AS_PROPS);
}
$data['ExposedPorts'] = $values_3;
} |
|
It might be cleaner to just set objects as so: if ($object->isInitialized('exposedPorts') && null !== $object->getExposedPorts()) {
$values_3 = [];
foreach ($object->getExposedPorts() as $key => $value_3) {
$values_4 = [];
foreach ($value_3 as $key_1 => $value_4) {
$values_4[$key_1] = $value_4;
}
$values_3[$key] = new \ArrayObject($values_4, \ArrayObject::ARRAY_AS_PROPS);
}
$data['ExposedPorts'] = new \ArrayObject($values_3, \ArrayObject::ARRAY_AS_PROPS);
} |
|
Or initialise as an array object: if ($object->isInitialized('exposedPorts') && null !== $object->getExposedPorts()) {
$values_3 = new \ArrayObject(array(), \ArrayObject::ARRAY_AS_PROPS);
foreach ($object->getExposedPorts() as $key => $value_3) {
$values_4 = new \ArrayObject(array(), \ArrayObject::ARRAY_AS_PROPS);
foreach ($value_3 as $key_1 => $value_4) {
$values_4[$key_1] = $value_4;
}
$values_3[$key] = $values_4;
}
$data['ExposedPorts'] = $values_3;
} |
|
Just an update, this holds true for any object which is empty regardless if it's an additionalProperties object. We're going through and manually patching $values = [];with $values = new \ArrayObject([], \ArrayObject::ARRAY_AS_PROPS);Anywhere in the specification where we are returning an object. It seems like this is a pretty big bug @Korbeil, I'll have another look at the codebase over the weekend and see if I can find any way to fix it myself. |
|
There is a trait |
|
This problem also exists for specs that contain string dictionaries, like this: buildingFields:
type: object
additionalProperties:
type: string
example:
Carport: "39 m²"
Outhouse: "8 m²"
nullable: trueWhen setting the field to {
"buildingFields":[]
}My expectation (and other consumers of this output) is that this would be an empty object instead (or Are there any solutions for this case? |
Jane version(s) affected: 7.4.1
Description
When the OpenAPI v3 spec is as so:
Empty additionalProperties are generated as an array rather than an object in the normalizer, whereas the denormalizer correctly creates an object.
How to reproduce
See above.
Possible Solution
additionalProperties normalizer and denormalizer should be the same.
Additional context
Here is the generated code:
Normalizer:
https://github.com/beluga-php/docker-php-api/blob/0082dac1f074aa56abe82d6f18aebb5823559921/src/Normalizer/ContainersCreatePostBodyNormalizer.php#L245-L251
Denormalizer:
https://github.com/beluga-php/docker-php-api/blob/0082dac1f074aa56abe82d6f18aebb5823559921/src/Normalizer/ContainersCreatePostBodyNormalizer.php#L80-L85
The text was updated successfully, but these errors were encountered: