Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Play next" option to song context menu #186

Open
albertschulz opened this issue May 5, 2022 · 3 comments
Open

Add "Play next" option to song context menu #186

albertschulz opened this issue May 5, 2022 · 3 comments

Comments

@albertschulz
Copy link

Hey there,
My use-case is to create a queue of 100 songs for 3 hours of playback during dance parties.
Once I added all songs, I usually reorder the songs, often while music is playing.
So far, I just discovered the drag-and-drop option to reorder. But its very painful if the song I want to play very next to the current song playing, is at the very end of the queue.
image

A "Play next" which puts it right after the current song in the queue would be a huge improvement for you.
What do you think?
Is that easy to implement? Would that be also useful to you? Can you give me a hint where I would need to do the change?

@janbar
Copy link
Owner

janbar commented May 6, 2022

You are in the queue playlist, so there is no way to do that. If you want to play as next you could long tap on the current playing track, then move it up to the track you want to play next.

@albertschulz
Copy link
Author

Thanks for the fast reply.
I agree that this is not possible until now.
Your proposed solution works, but is very painful when the queue gets longer than the screen size.

Please see the GIF below to see my pain, and also the solution I already implemented:
Peek 2022-05-06 14-28

You can find my branch here:
https://github.com/janbar/noson-app/compare/devel...albertschulz:albert/play-next?expand=1

Could I open a pull request for that?

@janbar
Copy link
Owner

janbar commented May 10, 2022

My code is a mess. I saw you anderstand my langage ;-).
We could do that also:
reorderTrackInQueue(player.currentIndex, model.trackIndex - 1);
Then it should play next and all the ones to follow.
A pull request is welcome. I will test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants