Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some options (e.g. wrapClass) are not applied after rebind #379

Open
techfg opened this issue Feb 17, 2021 · 0 comments
Open

some options (e.g. wrapClass) are not applied after rebind #379

techfg opened this issue Feb 17, 2021 · 0 comments
Labels

Comments

@techfg
Copy link
Collaborator

techfg commented Feb 17, 2021

Describe the bug
As documented, rebind applies the specified options to IM and redraws. However, certain options are not applied during the rebind. Examples of this include wrapClass, wrapCss, etc.

To Reproduce
Steps to reproduce the behavior:

  1. Go to jsFiddle
  2. Click on Rebind

Expected behavior
The class assigned to IM wrapper should change from wrapper to wrapper2. Note that for certain options, this could mean having to replace existing configuration (e.g. remove previous wrapper class and add current one).

Screenshots
N/A

Desktop (please complete the following information):
N/A

Smartphone (please complete the following information):
N/A

Additional context
The current code paths for initialization and rebind are separate, however much of the functionality required is identical. Likely makes sense to refactor this (and several other areas in the code) to re-use logic as part of the broader rewrite/refactor plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant