Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate enableAutoResizeSupport configuration option in next major release #361

Open
techfg opened this issue Jan 30, 2021 · 0 comments
Open

Comments

@techfg
Copy link
Collaborator

techfg commented Jan 30, 2021

Is your feature request related to a problem and/or adding functionality? Please describe.
In v.1.5.0, a basic autoresize feature was added. In order to add this feature in a 100% backwards compatible way, the configuration option enableAutoResizeSupport was added that enables the autoresize capability.

Describe the solution you'd like
In the next major release, the following should be done:

  1. Eliminate enableAutoResizeSupport configuration and make it the default behavior. In short, this would simply not apply a width/height to the wrapper div that IM inserts in to DOM. Whether or not to automatically resize images would be controlled via autoResize configuration parameter.
  2. Revisit the concept of autoscale vs. autoresize and consider having IM only be responsible for autoscaling but not autoresizing. In this case, IM would rely on the browser/CSS to resize images and when an images resizes, autoscaling would trigger to scale areas and apply css to canvas elements, etc.

Describe alternatives you've considered
N/A

Additional context
N/A

@techfg techfg added this to the 2.0.0 milestone Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant