Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning when attempting to close osci-render with unsaved changes #154

Open
jameshball opened this issue Jan 8, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@jameshball
Copy link
Owner

Currently, you can easily make lots of changes and close the program after forgetting to save, losing your progress.

The program title currently updates to include "unsaved files" at the top, but this only updates when you edit a file, and not when you change a slider value, for example.

For a decent first version of this, you could simply detect when any slider value has changed and then update the title accordingly. Later iterations of this could include monitoring updates text fields, and settings in the bar at the top.

This could work by having the MainController listen to all sub-controllers and whenever a value is changed, tell the MainController.

When closing osci-render, first check if there are unsaved changes, and open a pop-up window asking the user if they want to save before exiting or not.

@jameshball jameshball added the enhancement New feature or request label Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Ready
Development

No branches or pull requests

1 participant