Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FastImage to detect images that can't be downloaded #271

Open
ishields opened this issue Jun 14, 2020 · 1 comment
Open

Use FastImage to detect images that can't be downloaded #271

ishields opened this issue Jun 14, 2020 · 1 comment

Comments

@ishields
Copy link
Contributor

ishields commented Jun 14, 2020

I've noticed that meta_inspector returns urls of images that can't be downloaded. When download_images is enabled, we can actually use FastImage to detect non-found images.

This ticket is to track several changes:

  1. Add new option to download_image_options hash called "reject_invalid_images"
  2. When "download_images" and "reject_invalid_images" options are enabled, we should return nil when the og:image or twitter:image can't be downloaded
  3. When "download_images" and "fetch_all_image_meta" option is enabled, return a boolean "valid" indicating whether the image was found to be downloadable.
  4. When new option is specified "download_images" and "reject_invalid_images"remove any invalid images since they will not be usable.
@ishields ishields changed the title If download_images is enabled, test the owner_suggested image before returning Use FastImage to detect images that can't be downloaded Jun 14, 2020
@ishields
Copy link
Contributor Author

(I updated the description of this ticket to cover all features related to validity of the images.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant