Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add interval option for Update DM #1505

Open
4 tasks done
Kirdow opened this issue Mar 10, 2024 · 2 comments
Open
4 tasks done

[Feature Request] Add interval option for Update DM #1505

Kirdow opened this issue Mar 10, 2024 · 2 comments

Comments

@Kirdow
Copy link

Kirdow commented Mar 10, 2024

Is your feature request related to a problem? Please describe.

Whenever the bot DMs me about an update I often think it's someone asking for help rather than a bot sending a DM (As I only have DMs open for close friends and servers I act as support in). As I can't actually update it during the time I first get them, it's fairly inconvenient to get this same thing every day until the day I can actually update it as it takes my attention away from what I'm doing. I do however need to know when an update is out, so disabling the updatealerts option is not a solution, as I otherwise wouldn't know an update is out for possibly months.

What is your ideal solution to the problem?

Add an second option that allows you to specify an interval. I'd recommend hours or days. But at least something that allows us to specify how often we'll be reminded.

I did also see #983 where you mention valid points why not to add it. If you're still on par with that despite my own points, do prefer to add an option of when during the day the bot should DM. Currently I get the DMs at around 1pm. If I could instead choose something like 8pm that would also be acceptable.

How would this feature be used?

Let's say the option is called updatealerts.interval, here's a few examples of what different values would do, assuming hours:

  1. updatealerts.interval=24 - Sends a every day (Current behaviour).
  2. updatealerts.interval=48 - Sends a DM every 2 days.
  3. updatealerts.interval=168 - Sends a DM every week.
  4. updatealerts.interval=0 - Sends a DM only once.

As for the relation to #983 you'd possibly just have an option updatealerts.time which would be a 4 digit number specifying the time. 2000 would DM you at 8pm and 730 would DM you at 7:30am. This way you wouldn't need to change the 24 hour interval but could still allow us to get the DM when we're easily available.

Additional Info

I'm also very sensitive to notifications in general due to mental issues, mostly ones that aren't expected. If someone DMs me about needing help, that's fine. If my bot DM me about an update once, that's fine too. But once I get either spam (which I've disabled DMs from strangers for a reason) or if my bot starts DMing me on an interval when I need not to, it does stress me out heavily. So options like this really help me in the long run as it's basic accessibility settings at that point.

Checklist

@JetCrooked
Copy link

JetCrooked commented Mar 15, 2024

I second this suggestion, I'd love for the update alert dm to only be sent once after the update is released as sending it repeatedly is annoying and unnecessary imo.

I've blocked my bot in the meantime until I can update it, so as a temporary solution that's also something you can do to stop the dms lol
it's better than disabling update alerts in the config for two reasons: one, it's much quicker and easier to do (and let's be honest, if you're able to edit your config you're most likely also able to update the bot while you're there) and two, you can't forget you did it since you'll see blocked messages every time you use the bot so remembering to unblock it after updating won't be a problem, unlike disabling update alerts which as you rightfully pointed out you could very well forget to enable them again and therefore not be notified of the next update when it releases

@jagrosh
Copy link
Owner

jagrosh commented Mar 20, 2024

Frankly I'm not sure that adding this would be time well-spent, as it feels extremely niche for something that would have to be a lot more complicated than what is currently implemented (a simple scheduled executor). I'm leaving this issue open as I'm not necessarily opposed to having it if someone wanted to work on it and put the time in to make it feature-complete and optimized.

A few things to note in regards to how things currently are:

  • If you want alerts at a specific time of day, make sure that you start the bot around that time
  • If you only want some kind of notification one-time when a new version is released, you could do any of the following:
    • Join the support server and get the 'Music Updates' role
    • Enable Github's notifications for new releases (JMusicBot > 'Watch' > 'Custom' > 'Releases')
    • Block the bot once you get a DM (you'd have to remember to unblock when you update)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants