Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: can we upgrade the base image of jaeger-query? #5450

Closed
kevincantu opened this issue May 13, 2024 · 3 comments · Fixed by #5454 or #5465
Closed

[Feature]: can we upgrade the base image of jaeger-query? #5450

kevincantu opened this issue May 13, 2024 · 3 comments · Fixed by #5454 or #5465
Labels
enhancement good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@kevincantu
Copy link

Requirement

Patches for all the thingsss.

Problem

I see jaegertracing/jaeger-query:latest is still based on Alpine 3.16.9, and 3.16 is about to be EOL (ref).

Proposal

No response

Open questions

No response
@yurishkuro yurishkuro added help wanted Features that maintainers are willing to accept but do not have cycles to implement good first issue Good for beginners labels May 13, 2024
@yurishkuro
Copy link
Member

Instead of doing this manually, we should have dependabot do the upgrades automatically. However, I see that the image version is currently hardcoded in the Makefile, which dependabot probably won't be able to handle. it would be great to find a way to keep the version defined directly in some Dockerfile.

$ grx alpine .
./docker/Makefile:2:ROOT_IMAGE ?= alpine:3.16
./docker/Makefile:4:GOLANG_IMAGE := golang:1.22-alpine
./docker/Makefile:7:BASE_IMAGE ?= $(DOCKER_REGISTRY)/baseimg_alpine:latest
./docker/Makefile:8:DEBUG_IMAGE ?= $(DOCKER_REGISTRY)/debugimg_alpine:latest
./scripts/build-upload-a-docker-image.sh:19:		base_debug_img_arg="--build-arg base_image=localhost:5000/baseimg_alpine:latest --build-arg debug_image=localhost:5000/debugimg_alpine:latest "

This was referenced May 15, 2024
Closed
Merged
yurishkuro pushed a commit that referenced this issue May 16, 2024
@prakrit55
Fix alpine image to 3.19.0 (#5454)
5554e34 
## Which problem is this PR solving?
fixes: #5450

## Description of the changes
- changed alpine image tag from 3.16 to 3.19.0

## How was this change tested?
- 

## Checklist
- [ ] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [ ] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [ ] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---------

Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
@yurishkuro
Copy link
Member

https://github.com/jaegertracing/jaeger/pull/5454/files#r1606261791

@yurishkuro yurishkuro reopened this May 20, 2024
@prakrit55 prakrit55 mentioned this issue May 20, 2024
Merged
4 tasks
yurishkuro pushed a commit that referenced this issue May 20, 2024
@prakrit55
Remove args and depict the image in From directive (#5465)
2eee293 
<!--
!! Please DELETE this comment before posting.
We appreciate your contribution to the Jaeger project! 👋🎉
-->

## Which problem is this PR solving?
Fixes: #5450

## Checklist
- [ ] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [ ] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [ ] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---------

Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
@yurishkuro
Copy link
Member

dependabot is now upgrading alpine: #5469 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Milestone
No milestone
2 participants
@yurishkuro @kevincantu