Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jaeger-v2] Do away with storage.ArchiveFactory #5230

Closed
yurishkuro opened this issue Feb 25, 2024 · 3 comments
Closed

[jaeger-v2] Do away with storage.ArchiveFactory #5230

yurishkuro opened this issue Feb 25, 2024 · 3 comments
Labels

Comments

@yurishkuro
Copy link
Member

Per comment https://github.com/jaegertracing/jaeger/pull/5152/files#r1501916983

We need to get rid of storage.ArchiveFactory interface because it is conceptually meaningless - archive storage is just a storage that implements SpanStorage interface. It should be the same thing with Factory, just have a storage.Factory that in context can be interpreted as primary or archive. We unnecessarily bundle these two.

@h4shk4t
Copy link
Contributor

h4shk4t commented Feb 26, 2024

I would like to work on this.

@Wise-Wizard
Copy link
Contributor

Can I work on this issue?

@yurishkuro
Copy link
Member Author

I am gonna close this as I don't think it's necessary given how v2 storage is evolving. @james-ryans is working on defining a new storage APIs for v2 where there won't be archive storage as an explicit interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants