Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested change to frequency resolution #15

Open
mgold opened this issue Apr 17, 2015 · 4 comments
Open

Suggested change to frequency resolution #15

mgold opened this issue Apr 17, 2015 · 4 comments

Comments

@mgold
Copy link

mgold commented Apr 17, 2015

I'm referring to this page, figure 3, which seems to be working as intended but I found to be misleading.

At first I thought the samples better approximated an underlying analog curve. But it soon dawned on my that the horizontal time scale is not constant, and the curve compresses in from the right. This is because the sampling frequency is fixed and the time domain increases.

I think a more honest visualization is to show the underlying curve with sample points placed only on the left side. More points are added left to right as the slider is moved. Conceptually, equal horizontal spacing corresponds to the constant sampling rate.

This is unsolicited advice that you are free to take or leave as you like. I can also try implementing it myself if you assure me you'll merge it.

@mgold
Copy link
Author

mgold commented Apr 17, 2015

Although, doing so would break the charts on the next page, so I guess it's a wash. Maybe try to introduce it in the text a little more explicitly, which is certainly an easier solution than writing code.

@jackschaedler
Copy link
Owner

Hi Max,

This is a good point, and I initially had the same concern when writing these two sections. I'll see what I can do! I think a little visualization showing how much of the input signal is 'consumed' might help.

@mgold
Copy link
Author

mgold commented Apr 18, 2015

Thanks Jack. It's a really neat project, and enjoyed reading it.

@jackschaedler
Copy link
Owner

Thanks Max,

I appreciate it! Your visualization of Melkman's algorithm is really nicely done. And it's nice to see your work on the explorable explanations wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants