Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add to Unity Package Manager (UPM) #29

Open
codmw44 opened this issue May 12, 2020 · 6 comments
Open

[Enhancement] Add to Unity Package Manager (UPM) #29

codmw44 opened this issue May 12, 2020 · 6 comments

Comments

@codmw44
Copy link

codmw44 commented May 12, 2020

Unity doesn't have nuget. Unity has only UPM. Which have feature: "Add plugin via git".
Add packages to Unity project is more comfortably then via sources from zip
This tutorial may be helpful for add compatibility for UPM
https://www.patreon.com/posts/25070968

@MostHated
Copy link

I, too, would love to have this as a Unity package. Considering there is no reply to this, and no updates to the package in quite some time, I figure it is a long shot, but should this ever become a Unity package, it would be great to also add it to OpenUPM. https://openupm.com/

Thanks,
-MH

@jackmott
Copy link
Owner

jackmott commented Sep 18, 2020 via email

@MostHated
Copy link

MostHated commented Sep 18, 2020

I have not submitted anything to them myself, but I believe the majority of it goes by the repo having a Unity package manifest and the appropriate tags on the repo itself for versioning and categorization.

On a side note, is there anything specific you have to do to get this working with Unity? Upon trying to bring it in after building, pretty much every other Unity package ends up failing to load:

Details

I looked through the wiki, but I didn't see anything specific on it, just that it was compatible.

--- Edit, I just brought in the files themselves from the base package and see that I am missing Span<>, which I thought should be supported as part of C# 8 if I am not mistaken, but I dig deeper to see whats going on.

@jackmott
Copy link
Owner

Ohh, you might need to yank out span, or grab a version from before span was added. Don't know if unity supports that yet.

@MostHated
Copy link

How might I go about getting a version without span? Is there a specific commit I would have to grab? Normally I would check through the the "Releases" tab but it doesn't seem to be available on the repo.

I apologize, most of my C# experience over the last few years has revolves around Unity and as such I am not super familiar with nuget packages, do they include the source files when you download them? I typically prefer to use that and then create assembly definition files for them when I can to keep things consistent.

@jasonboukheir
Copy link

jasonboukheir commented Dec 1, 2020

I would also be interested in this!

FYI @MostHated the steps to install this package as a dll from nuget:

  1. Go to https://www.nuget.org/packages/LinqFaster/ and install the 1.0.0 base version of the library without Span. Here's a direct link to the download: https://www.nuget.org/api/v2/package/LinqFaster/1.0.0
  2. Rename the extension of the file from .nuget to .zip. (nuget files are just fancy zip files)
  3. Copy the contents of linqfaster.1.0.0/lib/netstandard2.0 folder to your Unity project.

For implementing this feature, it might be good to take a look at as a first step https://github.com/xoofx/UnityNuGet rather than OpenUPM?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants