Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Should these API's be marked with the [Pure] attribute #23

Open
Smurf-IV opened this issue Aug 2, 2019 · 2 comments
Open

Comments

@Smurf-IV
Copy link

Smurf-IV commented Aug 2, 2019

TLDR:
Indicates that a type or method is pure, that is, it does not make any visible state changes.

See https://docs.microsoft.com/en-us/dotnet/api/system.diagnostics.contracts.pureattribute?view=netframework-4.8

@ndrwrbgs
Copy link

For any that do not take a delegate, this would be okay. Those that do though have their purity implicit on the purity of the delegate, so would need to be omitted.
Do you want to send a PR adding it, Smurf?

@Smurf-IV
Copy link
Author

I've been trying to set-up seperate PR's but they keep being merged into the single outstanding one, so I gave up, and just Commented each with a relevant comment.
I'll wait until the Existing PR "Goes away"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants