Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snprintf buffer overflow after f42b8e3aac with pipewire versions containing 0e847c97 #85

Open
haasn opened this issue Sep 16, 2022 · 1 comment

Comments

@haasn
Copy link

haasn commented Sep 16, 2022

In pipewire commit 0e847c97 the jack port name size was bumped up to 513 (256+256+\0 byte), which is above the hard-coded limit of 512.

Possible solutions:

  1. Reverting the offending commit and simply live with the fact that your toaster running gcc 0.8-pre-alpha will not be able to compile nsm.
  2. Switch to using malloc to avoid the issue with dynamically sized arrays.
  3. Bump up the hard-coded limit to at least 513 and also add a safety cap to prevent this from buffer overflowing again.
@sbarbit
Copy link

sbarbit commented Feb 10, 2023

I've just bumped into the same issue. The fix involves the jackpatch.c source only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants