-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Response filters not being called #14
Comments
Hi, honestly I do not know. I coded CorePost as an experiment in my previous job and during the performance tests the equivalent Java Dropwizard version proved superior in nearly ever way (including CPU usage). As such I really do not do much in Python anything (actually nothing these days) and do most of my work during high perf realtime REST server apps in Java and Dropwizard. So if someone is interested in taking over CorePost and maintaining or forking it, I am very open to this. Sorry, I thought I'd rather be honest about what is the current status of the project :-/ |
I do remember having BDDs though that test both filters, so try and dig through the test apps in the BDD folder to see what I did there.... |
jacek99, Sorry to hear the project state is where it is, I think it's a very useful tool for Python/Twisted. I don't know much about Java, so I'm in the opposite boat. :) It looks like the method routing.__finishedDeferred(val, request) is the place to put a call to get the response filter to fire. I'll also look at the BBDs you mention and see if I can see how you tested both filters. Thanks for your help! Doug |
Hi jacek99, Looked at the test code and it only tests the response filters in the case where the get/post/whatever function is not decorated with @defer.inlineCallbacks unfortunately. I'm working on ways around this at the moment... Doug |
I'm using Corepost (which is great by the way) to build a Twisted application for a REST API. I coded up a response filter and passed it to to the RESTResource, but the filter is not being called. Following the code in a debugger it gets to routing.py and the getResponse() method, but it's bailing out at the "handle deferreds natively" if statement. Is there a way to get this to pass the response through the response filter I've set up?
The text was updated successfully, but these errors were encountered: