Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DecodeTxTimer wraparound with longTimer == true #3

Open
therealergo opened this issue Feb 26, 2024 · 0 comments
Open

DecodeTxTimer wraparound with longTimer == true #3

therealergo opened this issue Feb 26, 2024 · 0 comments

Comments

@therealergo
Copy link

If DecodeTxTimer in lcs_node.c is called with longTimer == true, then for values of txTimerIn exceeding 7 the returned value will exceed the range of a uint16_t type and produce unexpected results.

Returned values from DecodeTxTimer with txTimerIn in the valid range [0...15] are:
4096
6144
8192
12288
16384
24576
32768
49152
0
32768
0
0
0
0
0
0

I do not have a copy of the referenced "Tech Device Data Rev 1 p.9-17" (if there is a copy available please let me know!) but I suspect that this behavior is not intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant