Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of Facade in BaseViewFactory #2

Open
RemiCollin opened this issue Apr 6, 2015 · 0 comments
Open

Use of Facade in BaseViewFactory #2

RemiCollin opened this issue Apr 6, 2015 · 0 comments

Comments

@RemiCollin
Copy link
Contributor

The use of Facade in a package isn't generally regarded as a good pratice, as a user could use custom names for his class aliases in config/app.php.
A better way would be to use Illuminate\Contracts in place, and use a service provider to inject the dependency in class __construct() method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant