Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate.go branch does not fork explicitly referenced images #3125

Open
howardjohn opened this issue Jan 14, 2021 · 2 comments
Open

generate.go branch does not fork explicitly referenced images #3125

howardjohn opened this issue Jan 14, 2021 · 2 comments

Comments

@howardjohn
Copy link
Member

Some jobs have per-job image overrides. When we branch, these are ignored.

We should either automatically update these, or maybe at least warn about them so they can be addressed.

cc @istio/release-managers-1-9
@ericvn
Copy link
Contributor

ericvn commented Apr 13, 2021

cc @istio/release-managers-1-10 This was one of the noted items during the branching.

@Monkeyanator
Copy link
Contributor

cc @brian-avery who I followed up with on the specifics of the issues we had with the generate step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@howardjohn @Monkeyanator @ericvn