Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run branchprotector as a postsubmit #2299

Open
clarketm opened this issue Jan 24, 2020 · 0 comments
Open

Run branchprotector as a postsubmit #2299

clarketm opened this issue Jan 24, 2020 · 0 comments
Labels
asks-to-engprod help wanted Indicates a PR/Issue that needs community help prow
Projects
Prioritization

Comments

@clarketm
Copy link
Member

clarketm commented Jan 24, 2020 •
edited

It would be convenient to be able to update branch protection settings on postsubmit – when changes are applied to the branch-protection Prow configuration. This would allow the changes to be picked up immediately without needing to wait for the periodic to fire off.

In general, having a generic tool/script run in postsubmit to do diffing and perform some routine if there is a diff would be helpful.

e.g.
change: #2298
effect: istio/proxy#2630
@clarketm clarketm self-assigned this Jan 24, 2020
@clarketm clarketm added the help wanted Indicates a PR/Issue that needs community help label Mar 13, 2020
@istio-policy-bot istio-policy-bot added the lifecycle/needs-triage Indicates a new PR or issue needs to be triaged label Mar 13, 2020
@clarketm clarketm removed the lifecycle/needs-triage Indicates a new PR or issue needs to be triaged label Mar 14, 2020
@clarketm clarketm removed their assignment Mar 14, 2020
@howardjohn howardjohn added this to > P2 in Prioritization Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
asks-to-engprod help wanted Indicates a PR/Issue that needs community help prow
Projects
Prioritization
> P2
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clarketm @istio-policy-bot