Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default helm installation steps doesn't work for k8s ingress #13497

Open
networkhermit opened this issue Jul 2, 2023 · 1 comment · May be fixed by #13516
Open

default helm installation steps doesn't work for k8s ingress #13497

networkhermit opened this issue Jul 2, 2023 · 1 comment · May be fixed by #13516
Assignees
@dhawton

Comments

@networkhermit
Copy link

https://istio.io/latest/docs/setup/install/helm/#installation-steps

8. (Optional) Install an ingress gateway:

$ kubectl create namespace istio-ingress
$ helm install istio-ingress istio/gateway -n istio-ingress --wait

Following the above official steps to install istio doesn't work for k8s ingress, as the default values of ingressService and ingressSelector is istio-ingressgateway and ingressgateway respectly in MeshConfig.

We should at least change the example release name from istio-ingress to istio-ingressgateway, as did by artifacthub example and gateway setup example, so the default helm installation steps works out of the box for k8s ingress.

A lot of people have stumbled upon this issue:

istio/istio#36444 (comment)
istio/istio#37329
istio/istio#44402
@dhawton dhawton self-assigned this Jul 6, 2023
@dhawton dhawton linked a pull request Jul 6, 2023 that will close this issue
Open
10 tasks
@SebTardif
Copy link

I have seen projects where all examples in the documentation itself are packaged in a way that they are all executed part of the test suite, so it become harder to create stale documentation by renaming one thing somewhere else. I have also seen project where commit are very hard to get approved without a lot of work on the matching documentation, like if the documentation quality was taken seriously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhawton dhawton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update istio-ingress installation name in helm install instructions dhawton/istio.io
3 participants
@dhawton @SebTardif @networkhermit