Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can we support "auto alphabetical order under" when add member in local ? #1092

Open
samzong opened this issue Jun 19, 2023 · 5 comments
Open
Assignees

Comments

@samzong
Copy link
Member

samzong commented Jun 19, 2023

like this.

  • first, add your name in org/memeber.yaml
  • second, run make format org/memeber.yaml

A simple script is all that's needed.

@howardjohn
Copy link
Member

PRs welcome if there is a good way to do this. fwiw I normally use IDE function to do it, but simple script would be nice

@ronitblenz
Copy link

I would like to try this. Assign me :)

@ronitblenz
Copy link

Some updates:

The script is running fine!

go run sort_names.go
Names sorted successfully!

But the catch is that we cant have two main func in a directory. So, I had to make a subfolder for members to fix this issue.

Now I have to make changes in the config_test.go.

@ronitblenz
Copy link

Hey @howardjohn @samzong

I discovered a Quick Fix for it. I have made a directory called members, where you can add your name randomly. Now the script sorts the YAML and makes a copy of the tempname.yaml to generate updated members.yaml.

Screenshot 2023-06-30 at 1 27 53 PM

@ericvn
Copy link
Contributor

ericvn commented Jul 5, 2023

I don't think we want to have people enter their names in multiple places. This leads to potential issues with changes overriding others or changes being lost. Maybe you have a script to grab the section from the member.yaml, sort it and put it back.

And how are you adding the updated list back into the PR. Are you having the automation create a new commit with the updated list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants