Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use standard Envoy interval reporting for telemetry #43763

Closed
kyessenov opened this issue Mar 3, 2023 · 10 comments · May be fixed by istio/api#2721
Closed

use standard Envoy interval reporting for telemetry #43763

kyessenov opened this issue Mar 3, 2023 · 10 comments · May be fixed by istio/api#2721
Labels
lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while

Comments

@kyessenov
Copy link
Contributor

Envoy has added a standard access_log_flush_interval feature to access logs. We should remove custom Istio code duplicating this feature and switch to the upstream way - this will help eventual transition to the standard OTLP and telemetry sinks.

A possible issue is that TCP stats sets it to 15s, but the envoy option applies to all sinks at the same time.
@kyessenov
Copy link
Contributor Author

cc @zirain @lei-tang

@Kaushal28
Copy link
Contributor

@kyessenov, I would like to contribute here, could you please provide me with some more details if you have or any entry point in Istio code from where I can start?

@zengyuxing007
Copy link
Contributor

buffer_flush_interval ? this parameter should probably be placed under the Provider associated with the log

@zirain
Copy link
Member

zirain commented Mar 8, 2023

@kyessenov do you means access_log_flush_interval on TcpProxy

@kyessenov
Copy link
Contributor Author

@zirain Yeah, and there is another one for HTTP after envoyproxy/envoy#25824. I think it's better than having our stats filters doing the same thing.

@zirain
Copy link
Member

zirain commented Mar 8, 2023

are you talking about promte tcp_reporting_duration to upstream and resue it?

@kyessenov
Copy link
Contributor Author

We don't need to implement upstream - it's done by others. We should align our APIs to upstream better - so that the reporting duration is consistent across all sinks. E.g. the same reporting duration knos applies for OTel, stats, etc.

@zirain
Copy link
Member

zirain commented Mar 8, 2023

make senses

@kyessenov kyessenov mentioned this issue Mar 16, 2023
Open
@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Jun 6, 2023
@istio-policy-bot istio-policy-bot added the lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. label Jun 21, 2023
@kyessenov kyessenov reopened this Jun 21, 2023
@istio-policy-bot istio-policy-bot removed the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Jun 21, 2023
@kyessenov
Copy link
Contributor Author

This is future looking, for Otel.

@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Sep 20, 2023
@istio-policy-bot
Copy link

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2023-06-21. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

telemetry: periodic reporting kyessenov/api
5 participants
@zengyuxing007 @zirain @kyessenov @Kaushal28 @istio-policy-bot