Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Accidental file truncation by attempted write when permission denied. #2349

Open
kuflierl opened this issue Feb 24, 2024 · 1 comment
Open

[Bug] Accidental file truncation by attempted write when permission denied. #2349

kuflierl opened this issue Feb 24, 2024 · 1 comment
Labels
unconfirmed

Comments

@kuflierl
Copy link

Attempting to write to a file the current user has no write permissions for results in the file being truncated.

This can lead to accidental data loss
kuflierl added a commit to kuflierl/ish that referenced this issue Feb 24, 2024
@kuflierl
fix ish-app#ish-app#2349 by performing a stat before opening the back…
1b4be62 
…end instead of a fstat after opening the file
kuflierl added a commit to kuflierl/ish that referenced this issue Feb 24, 2024
@kuflierl
fix ish-app#2349 by performing a stat before opening the backend inst…
cb756ea 
…ead of a fstat after opening the file
@kuflierl
Copy link
Author

The PR #2352 should fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
unconfirmed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kuflierl