Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong or missing arguments when calculating SMA #9

Open
wmitnaj opened this issue May 3, 2023 · 8 comments
Open

Wrong or missing arguments when calculating SMA #9

wmitnaj opened this issue May 3, 2023 · 8 comments

Comments

@wmitnaj
Copy link

wmitnaj commented May 3, 2023

Hi,

I did some tests on a demo broker account and the sma command seems to either be wrong or is missing an argument because it always returns "Error: min_periods must be an integer". After that, AutoGPT tried the sma command with the min_periods argument, which resulted in another error "Error: AutoGPTMetaTraderPlugin.sma() got an unexpected keyword argument 'min_periods'.

After that, all the other indicators were calculated correctly but the system crashed due to the message finally being to long for openai to handle and I got the "message is too long" error.
SMAError

@isaiahbjork
Copy link
Owner

isaiahbjork commented May 3, 2023

Hi,

I did some tests on a demo broker account and the sma command seems to either be wrong or is missing an argument because it always returns "Error: min_periods must be an integer". After that, AutoGPT tried the sma command with the min_periods argument, which resulted in another error "Error: AutoGPTMetaTraderPlugin.sma() got an unexpected keyword argument 'min_periods'.

After that, all the other indicators were calculated correctly but the system crashed due to the message finally being to long for openai to handle and I got the "message is too long" error.

SMAError

That's not a valid argument that's why, tell it to only use period. Sometimes it uses arguments that aren't allowed which is a bug and hopefully gets fixed in the future. I'll review it though and check the error on my end.

@isaiahbjork
Copy link
Owner

What command had a message that was too long? I tried to make sure that wouldn't happen with the data it pulls in.

@wmitnaj
Copy link
Author

wmitnaj commented May 3, 2023

The initial goal was something like "Analyse the candlestick data of EURUSD and make smart trades to increase the net worth of the broker account". The command that crashed the system with a message that was too long was one of the other indicators after the sma. It had like 4317 characters and it said 4096 is the maximum. But I have to reproduce it to be sure which command it was.

@isaiahbjork
Copy link
Owner

The initial goal was something like "Analyse the candlestick data of EURUSD and make smart trades to increase the net worth of the broker account". The command that crashed the system with a message that was too long was one of the other indicators after the sma. It had like 4317 characters and it said 4096 is the maximum. But I have to reproduce it to be sure which command it was.

If you could reproduce the error that would be helpful so I can make sure it doesn't happen again

@wmitnaj
Copy link
Author

wmitnaj commented May 3, 2023

It seems like at least the "message too long" error was simply my fault, because I didnt start autoGPT with --gpt3only. I fixed that and now the message problem seems to be fixed. But I still get the "Error: min_periods must be an integer" error everytime it tries to do the sma indicator, no matter how often I say it should only use period.

@wmitnaj
Copy link
Author

wmitnaj commented May 3, 2023

In the meantime I did another test, it runs for about 10 Minutes now and basically loops through all the indicators but gets them wrong regularly as seen in the attached picture. When it finally tried to do a trade on the demo account, it got an error that trades are disabled, but I can trade via MT 4 fine. Maybe the api is disabled in the demo account?
Errors

@isaiahbjork
Copy link
Owner

In the meantime I did another test, it runs for about 10 Minutes now and basically loops through all the indicators but gets them wrong regularly as seen in the attached picture. When it finally tried to do a trade on the demo account, it got an error that trades are disabled, but I can trade via MT 4 fine. Maybe the api is disabled in the demo account?
Errors

I've been using it on demo and its working fine and those indicators are working fine for me so that's weird. I will take a look again later tonight to see if I can reproduce your errors on my end and try to fix them.

@toobongo999
Copy link

I also have the "Error: min_periods must be an integer" error, and then it tries to add it in and then gets the follow up error. I also added 'min_periods' into the init.py file in the metatrader zip folder, but this also didn't work, so took it out again. Interested to see if anyone comes up with a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants