Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split irods_common_core and irods_lib_core_[client|server] into separate directories. #7738

Open
SwooshyCueb opened this issue May 10, 2024 · 3 comments
Assignees
Milestone

Comments

@SwooshyCueb
Copy link
Member

The irods_common_core and irods_lib_core_[client|server] targets are defined in lib/core:

add_library(
irods_common_core

add_library(
irods_lib_core_${variant}

Let's split them into separate directories.

Some decisions will need to be made:

  • Whether irods_common_core or irods_lib_core_[client|server] will remain in the core directory
  • What the new directory shall be named
  • What the new target names shall be

There may also be headers that do not clearly belong to one or the other.

@SwooshyCueb SwooshyCueb added this to the 4.3.4 milestone May 10, 2024
@SwooshyCueb SwooshyCueb self-assigned this May 10, 2024
@trel
Copy link
Member

trel commented May 10, 2024

presumably we have a common because there are things for both? why split them? because composability is easy/good?

@SwooshyCueb
Copy link
Member Author

irods_common_core is an object library used to make libirods_common.
irods_lib_core_client and irods_lib_core_server are two object libraries made from the same source files used to make libirods_client and libirods_server, respectively.
It doesn't make sense to me to have them live in the same directory.

@trel
Copy link
Member

trel commented May 10, 2024

fair enough - if we're building the same targets in the end... nobody downstream needs to know/care i presume...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants