Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore using system-provided nlohmann-json #7726

Open
SwooshyCueb opened this issue May 3, 2024 · 0 comments
Open

Explore using system-provided nlohmann-json #7726

SwooshyCueb opened this issue May 3, 2024 · 0 comments
Assignees
Milestone

Comments

@SwooshyCueb
Copy link
Member

At present, we use an externals package for nlohmann-json, specifically version 3.10.4.
Theoretically, we only need 3.6.1, though this has not been tested in quite some time:

find_package(nlohmann_json "3.6.1" REQUIRED)

It may be possible for us to drop the externals package and use distro-provided packages instead; all distros we support (or plan to) have at least 3.6.1:

Distribution Repository Package name Version Package revision
EL7 EPEL json-devel 3.6.1 2.el7
EL8 EPEL json-devel 3.6.1 2.el8
EL9 EPEL json-devel 3.11.3 1.el9
Ubuntu 20.04 universe nlohmann-json3-dev 3.7.3 1
Ubuntu 22.04 universe nlohmann-json3-dev 3.10.5 2
Ubuntu 24.04 universe nlohmann-json3-dev 3.11.3 1
Debian 11 main nlohmann-json3-dev 3.9.1 1
Debian 12 main nlohmann-json3-dev 3.11.2 2

Let's give it a whirl.

@SwooshyCueb SwooshyCueb added this to the 4.3.3 milestone May 3, 2024
@SwooshyCueb SwooshyCueb self-assigned this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant