New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic Auth Base64 endocding #47

Open

ximex opened this issue Apr 7, 2015 · 0 comments

ximex commented Apr 7, 2015

There is a problem with usernames/passwords with special chars like ä,ö,ü.

The problem is this part:
https://github.com/iriscouch/browser-request/blob/master/index.js#L433-L472

If i take the function from the original request lib it works:
https://github.com/request/request/blob/master/lib/helpers.js#L45-L47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment