Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext/getaddress api with array of last txs #392

Closed
GamSui opened this issue Jun 30, 2020 · 9 comments · Fixed by #410
Closed

ext/getaddress api with array of last txs #392

GamSui opened this issue Jun 30, 2020 · 9 comments · Fixed by #410
Assignees

Comments

@GamSui
Copy link

GamSui commented Jun 30, 2020

In some installations I can see that the ".../ext/getaddress" api returns a list of last txs. I'm using quite an old version 1.6.1. In my installation I only get address, sent, received and balance. I don't get the last txs array. Is this a restriction of my current version, or can I active this feature? If yes how?

@TheHolyRoger
Copy link
Collaborator

Where have you seen that? This isn't currently in the original fork.

If you can link it we will replicate it.

@uaktags
Copy link
Collaborator

uaktags commented Jul 19, 2020

It may have been part of the change from
Address.findOne() to AddressTx.findOne()
Briefly looked at the last push that iquidus made to database.js and noticed the difference in our models for the find_address.

So before, only responded with the address dcoument rather than the AddressTX document

@TheHolyRoger
Copy link
Collaborator

Ahhh, right got you. I remember stripping that out thinking it was redundant. I think that still existed in 1.6.1 though which is odd... Will look into bringing this back

@TheHolyRoger TheHolyRoger self-assigned this Jul 19, 2020
@TheHolyRoger TheHolyRoger pinned this issue Jul 19, 2020
@GamSui
Copy link
Author

GamSui commented Jul 20, 2020

Thanks for your replies.

I have seen it on the following live explorer sites (all powered by Iquidus Explorer). So I assumed if this can be found on several instances it cannot be a custom implementation).

http://explorer.omegablockchain.net/ext/getaddress/oSVLhptBjB7jv8F4nuwfDBYoaRhmRQug3g
https://explorer.maxcoinproject.net/ext/getaddress/mVameADsUKcSeFUv47bShXzc424KVoEtUq
http://altmco.in/ext/getaddress/Aburni676T6PWnPUiM8Knb3W3Eyt6t7LFt
http://gcpool.eu:3590/ext/getaddress/NNBCACPrrDQZA4C6Gi8pYZe5VRVoNao6GE

Would be great if you can bring it back. Thanks a lot!

@FrediDealCash
Copy link

I have just opened the following issue: #408

I am running the latest v of the explorer and also need the above functionality to get the last txs for a specific address

@TheHolyRoger
Copy link
Collaborator

I'll take a look at this later we don't need to change much to get this back in

@FrediDealCash
Copy link

I'll take a look at this later we don't need to change much to get this back in

Amazing - that would be great. Thanks!

@TheHolyRoger
Copy link
Collaborator

@FrediDealCash @GamSui Please try out this PR:

#410

@FrediDealCash
Copy link

@FrediDealCash @GamSui Please try out this PR:

#410

Just tried it and have left my comment on the PR: #410 (review)

All works perfectly, thank you very much for taking the time to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants