Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emojify-display-emojis-in-company-tooltip should not force the use of after-string #112

Open
dgutov opened this issue Nov 26, 2023 · 0 comments

Comments

@dgutov
Copy link

dgutov commented Nov 26, 2023

I'm not crazy about the advice approach at all, but your particular one is also based on outdated information. Company's popup doesn't use display anymore, we settled on 'before-string. That's how the kind icons are able to be rendered, too.

So the end of the advice should be changed.

You can also try advicing company-fill-propertize instead (with an after advice), that should allow a much shorter definition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant