Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.35.0 does not work on Intel Macs #2809

Closed
core-code opened this issue May 14, 2024 · 14 comments · Fixed by #2811
Closed

v0.35.0 does not work on Intel Macs #2809

core-code opened this issue May 14, 2024 · 14 comments · Fixed by #2811
Assignees
Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization P0 Critical: Tackled by core team ASAP

Comments

@core-code
Copy link

v0.35.0 is ARM/"AppleSilicon" only, and cannot be launched on Intel Macs:

Screenshot 2024-05-14 at 12 57 47
@core-code core-code added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels May 14, 2024
Copy link

welcome bot commented May 14, 2024

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

@jc-frosty
Copy link

TLDR: When compiled yourself on such a system it runs.
I updated the application using its built in update function and ran into this issue. I thought this might be an issue with compiling or packaging and so I built it on my machine from source and the application compiled and built fine, it just has to be run from the directory that I built it in using the command npm start in a cli environment. ifs desktop just runs under electron.
MacOS Monterey
Mac Pro 6,1(intel)
IPFS desktop Revision: d137048
If future versions do become version or chip(apple silicon vs intel) specific, I would recommend implementing a step in the update process that checks whether the update is compatible with the system.

@sevenoh7
Copy link

Can you guide me how to build from source? I'm also having issues getting it to run on Monterey

@core-code
Copy link
Author

should be addresses upstream instead of trying to build from source. @lidel ?

@jc-frosty
Copy link

jc-frosty commented May 16, 2024

Building from source is just a work around until the issue is fixed upstream.

@jc-frosty
Copy link

Can you guide me how to build from source? I'm also having issues getting it to run on Monterey

Instructions

@d70-t
Copy link

d70-t commented May 16, 2024

One annoying thing about this issue is, that even if I downgrade to the previous version (which works fine), the auto-updater keeps breaking my installation after a while.

@lidel
Copy link
Member

lidel commented May 16, 2024

Thank you for reporting this and confirming local build works.

Seems something changed on Apple's side, or gitbub worker's side, because the only code difference between 0.34 and 0.35 is updating Kubo version:

v0.34.0...v0.35.0

Will look into this.

Temporary workaround

Until we have a bugfix release, a workaround is to downgrade to 0
automatic updates can be disabled via config:

function isAutoUpdateSupported () {
if (store.get(CONFIG_KEYS.DISABLE_AUTO_UPDATE, false)) {
logger.info('[updater] auto update explicitly disabled, not checking for updates automatically')
return false

Find config.json in your IPFS Desktop app's profile directory and add disableAutoUpdate set to true:

{
	"ipfsConfig": {
		"path": "",
		"flags": [
			"--agent-version-suffix=desktop",
			"--migrate",
			"--enable-gc"
		]
	},
	"language": "",
	"experiments": {},
	"binaryPath": "",
	"__internal__": {
		"migrations": {
			"version": "0.35.0"
		}
	},
	"automaticGC": true,
+        "disableAutoUpdate": true,
	"openWebUIAtLaunch": true,
	"window": {
		"width": 1628,
		"height": 683
	}
}

If you do this, set a reminder to remove it at some point in the future, or you will be stuck with an old version that may get insecure over time.

@lidel lidel added the P0 Critical: Tackled by core team ASAP label May 16, 2024
@lidel lidel self-assigned this May 16, 2024
@core-code
Copy link
Author

the change is on github's side, they default to building on (and for) ARM now

@lidel
Copy link
Member

lidel commented May 16, 2024

Indeed, seems this caught a lot of projects by surprise:

actions/runner#3256

Sounds like the most expedient fix is to downgrade mac builder to macos-13 image. Will give it a try and if that works, will ship a patch release.

@lidel
Copy link
Member

lidel commented May 16, 2024

Shipped v0.35.1, hopefully solves the problem at hand, restoring Intel functionality.

Follow-up work is tracked in #2813

@core-code
Copy link
Author

thanks, confirmed resolved.

@lidel
Copy link
Member

lidel commented May 17, 2024

Thanks for confirming @core-code

Btw: since you have intel-based Mac, mind checking if the universal version linked here also works on your machine? (comment on #1856 (comment))

@core-code
Copy link
Author

seems to launch fine here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization P0 Critical: Tackled by core team ASAP
Projects
No open projects
Status: No status
Development

Successfully merging a pull request may close this issue.

5 participants