Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read_comparable_areas giving 522 AMCs #319

Open
gabriel-berga opened this issue Jun 2, 2023 · 4 comments
Open

read_comparable_areas giving 522 AMCs #319

gabriel-berga opened this issue Jun 2, 2023 · 4 comments
Assignees

Comments

@gabriel-berga
Copy link

Hello there,

When I use the read_comparable_areas(start_year=1872, end_year = 2010) function the database has 522 AMCs, while Ehrl creates 482 AMCS using the same period. I'm not sure if I'm making some mistake, or if there is some problem with this function in the package.

Regards,

@rafapereirabr
Copy link
Member

@PedroJorge7 , could you please have a look at this issue?

@fbrustolin-fep
Copy link

Today, just comparing the number of AMCs, I found:

  • read_comparable_areas(start_year=1872, end_year = 2010): 522 x 482 (Ehrl) AMCs
  • read_comparable_areas(start_year=1920, end_year = 2010): 1043 x 1030 (Ehrl) AMCs
  • read_comparable_areas(start_year=1970, end_year = 2010): 3800 x 3800 (Ehrl) AMCs
  • read_comparable_areas(start_year=1991, end_year = 2010): 4298 x 4298 (Ehrl) AMCs
  • read_comparable_areas(start_year=2000, end_year = 2010): 5476 x 5474 (Ehrl) AMCs

Regards,

@PedroJorge7
Copy link
Contributor

PedroJorge7 commented Dec 12, 2023

Hello @fbrustolin-fep ,

I apologize for the delayed response. During this period, we have been conducting various tests and adjustments in search of differences between the AMCs in our code and the output from Ehrl.

We have finally found a result that is more consistent and aligned with what was observed with Ehrl (We will be uploading these adjustments soon). Following your example:

  • read_comparable_areas(start_year=1872, end_year = 2010): 482x 482 (Ehrl) AMCs
  • read_comparable_areas(start_year=1920, end_year = 2010): 1029 x 1030 (Ehrl) AMCs
  • read_comparable_areas(start_year=1970, end_year = 2010): 3799 x 3800 (Ehrl) AMCs
  • read_comparable_areas(start_year=1991, end_year = 2010): 4298 x 4298 (Ehrl) AMCs
  • read_comparable_areas(start_year=2000, end_year = 2010): 5476 x 5476 (Ehrl) AMCs

Note that there is a difference of one AMC between 1920-2010 and 1970-2010. However, it seems that our code is functioning correctly. This AMC difference is caused by Mossoró that in Ehrl code, does not share the same AMC as Serra do Mel, but in the original file, it appears to do. So, they should be considered a single AMC.

Attached are some screenshots from our comparative analysis:

image
image

@fbrustolin-fep
Copy link

Thank you so much, @PedroJorge7 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants