Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Menu Drag-Gestures bugs since Cordova-ios@6.1.0 #21876

Closed
EinfachHans opened this issue Aug 4, 2020 · 14 comments
Closed

bug: Menu Drag-Gestures bugs since Cordova-ios@6.1.0 #21876

EinfachHans opened this issue Aug 4, 2020 · 14 comments
Labels

Comments

@EinfachHans
Copy link
Contributor

Bug Report

Ionic version:

[ ] 4.x
[x] 5.x

Current behavior:

I just upgraded my App from cordova-ios 5.1.1 to 6.1.0. Now the Menu bugs while drag gesture. See the attached Video: https://www.dropbox.com/s/r4kvp9vsz6vfu7v/Ionic%20Bug.MP4?dl=0

Expected behavior:

Not to bug while dragging 😃

Ionic info:

Ionic CLI                     : 6.11.0 (/usr/local/lib/node_modules/@ionic/cli)
   Ionic Framework               : @ionic/angular 5.3.1
   @angular-devkit/build-angular : 0.1000.5
   @angular-devkit/schematics    : 10.0.5
   @angular/cli                  : 10.0.5
   @ionic/angular-toolkit        : 2.3.0

Cordova:

   Cordova CLI       : 9.0.0 (cordova-lib@9.0.1)
   Cordova Platforms : ios 6.1.0-dev
   Cordova Plugins   : cordova-plugin-ionic-keyboard 2.2.0, cordova-plugin-ionic-webview 5.0.0, (and 50 other plugins)

Utility:

   cordova-res : 0.15.1
   native-run  : 1.0.0

System:

   Android SDK Tools : 25.2.3 (/Users/hanskrywalsky/Library/Android/sdk)
   ios-deploy        : 1.10.0
   ios-sim           : 8.0.2
   NodeJS            : v12.16.1 (/usr/local/bin/node)
   npm               : 6.14.7
   OS                : macOS Catalina
   Xcode             : Xcode 11.6 Build version 11E708
@ionitron-bot ionitron-bot bot added the triage label Aug 4, 2020
@liamdebeasi liamdebeasi added the ionitron: needs reproduction a code reproduction is needed from the issue author label Aug 4, 2020
@ionitron-bot
Copy link

ionitron-bot bot commented Aug 4, 2020

Thanks for the issue! This issue has been labeled as needs reproduction. This label is added to issues that need a code reproduction.

Please provide a reproduction with the minimum amount of code required to reproduce the issue. Without a reliable code reproduction, it is unlikely we will be able to resolve the issue, leading to it being closed.

For a guide on how to create a good reproduction, see our Contributing Guide.

@ionitron-bot ionitron-bot bot removed the triage label Aug 4, 2020
@EinfachHans
Copy link
Contributor Author

EinfachHans commented Aug 4, 2020

Hey @liamdebeasi 😊
I just created this Repo: https://github.com/HansKrywaa/ionic-menu-bug

Additional Info: I don't use cordova-ios@6.1.0 directly, i uses this Fork, because it uses the latest cordova-common, which resolves some other Issues. The Problem seems to be because of this, but because this will be released in a future Version it should work as well? 🤔

@liamdebeasi
Copy link
Contributor

Does this issue happen when using an official version of cordova-ios? If this is only happening using a fork, it likely is not a bug in Ionic Framework.

@liamdebeasi liamdebeasi added needs: reply the issue needs a response from the user and removed ionitron: needs reproduction a code reproduction is needed from the issue author labels Aug 5, 2020
@EinfachHans
Copy link
Contributor Author

It happens if i use the Fork, BUT the only Change to 6.1.0 is that the Fork uses the Master Branch of cordova-common, instead of 4.0.1 (See here). So as this Changes in cordova-common will be released in a Future Version, this Changes will be relevant? 🤔

@ionitron-bot ionitron-bot bot added triage and removed needs: reply the issue needs a response from the user labels Aug 5, 2020
@liamdebeasi
Copy link
Contributor

What version of iOS are you testing this on?

@liamdebeasi liamdebeasi added the needs: reply the issue needs a response from the user label Aug 5, 2020
@ionitron-bot ionitron-bot bot removed the triage label Aug 5, 2020
@EinfachHans
Copy link
Contributor Author

13.6 iPhone 11 Pro

@ionitron-bot ionitron-bot bot added triage and removed needs: reply the issue needs a response from the user labels Aug 5, 2020
@liamdebeasi
Copy link
Contributor

Thanks! I can reproduce this on Cordova, but not on Capacitor. Seems to be a bug in Cordova, but I will keep digging.

@liamdebeasi
Copy link
Contributor

The issue appeared after this PR (apache/cordova-ios#790) in cordova-ios@6.0.0. For now, I recommend sticking with cordova-ios@5.1.1 or using Capacitor.

@EinfachHans
Copy link
Contributor Author

EinfachHans commented Aug 5, 2020

Capacitor is sadly not possible, because the main part of out app is Google Maps. Also I'm using cordova-ios@6.1.0 without this Bug. Only the Fork with the other cordova-common makes this buggy 🤔 So can it really be because of a PR in 6.0.0?

@liamdebeasi
Copy link
Contributor

I was able to reproduce this issue in stable versions of cordova-ios 6.0.0 and 6.1.0 (but not 5.1.1). I cloned cordova-ios and built it locally, resetting commits until I found that the bug happens only after apache/cordova-ios#790.

(Also, the Google Maps developer is working on a Capacitor plugin mapsplugin/cordova-plugin-googlemaps#2781 😄 )

@EinfachHans
Copy link
Contributor Author

Okay i will open a Issue in Cordova-Ios for the Moment 😊 Thank you!

@liamdebeasi
Copy link
Contributor

I further isolated the issue. It looks there is some kind of performance problem with Cordova when managing Web Animations. I will create a reproduction and add a follow up to your issue.

Once I do that I will close this issue out. Thanks!

@liamdebeasi
Copy link
Contributor

Hmm it looks like I was using some cached dependencies when I did my original test.

I can reproduce this issue on cordova-ios@6.0.0 and on your fork, but not on cordova-ios@6.1.0. I am not entirely sure why this bug is happening -- it looks like a performance issue from my end. I recommend sticking with stable versions of cordova for now. If the issue appears in a stable release of cordova-ios, we can take another look.

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 4, 2020

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants