Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Astro Functions prior to to 18h #1427

Open
Grothesk242 opened this issue Oct 30, 2023 · 7 comments
Open

No Astro Functions prior to to 18h #1427

Grothesk242 opened this issue Oct 30, 2023 · 7 comments
Labels

Comments

@Grothesk242
Copy link

When sunset is earlier than 18h, the adapter does show 18h as the earliest time.
There are no additional restrictions (e.g. Not Earlier than XY) set in the adapter.

@winnyschuster
Copy link
Contributor

not sure if it should be like it is now but if you are only interested in real values you can set the Not Earlier fields to something real early, like 15::00 for sunset

@Grothesk242
Copy link
Author

This is the workaround that I use for the moment. But it's still a bug from my view, at least it's an unexpected behaviour.

@winnyschuster
Copy link
Contributor

its not a bug, these values are set intentionally in case fields are empty(== undefined). However, i fully agree that its an unexpected behaviour. At least fields should be filled with these default so the user knows they should'nt be left empty

@Grothesk242
Copy link
Author

I would expect that in case of an empty field the real astro times would be considered.

@klein0r
Copy link
Collaborator

klein0r commented Nov 6, 2023

There are no additional restrictions (e.g. Not Earlier than XY) set in the adapter.

Please share your instance configuration - default is 18:00

Screenshot 2023-11-06 at 13 23 08

@klein0r
Copy link
Collaborator

klein0r commented Nov 6, 2023

"sunsetLimitStart": "18:00",

Okay, this is the problem:

if (settings.sunsetLimitStart === undefined) {
settings.sunsetLimitStart = '18:00';
}

@klein0r klein0r added the bug label Nov 6, 2023
@Grothesk242
Copy link
Author

I'd recommend to set these defaults to times that are during bright daylight to avoid this unexpected behaviour. Or make these default settings visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants