Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors deprecated node modules on start #1384

Open
Eistee82 opened this issue Aug 19, 2023 · 3 comments
Open

Errors deprecated node modules on start #1384

Eistee82 opened this issue Aug 19, 2023 · 3 comments
Labels

Comments

@Eistee82
Copy link

Describe the bug
I get errors on start of the Adapter

To Reproduce
Start the Adapter.

Expected behavior
No Errors on start.

Screenshots & Logfiles
image

Versions:

  • Adapter version: 7.1.4
  • JS-Controller version: 5.0.12
  • Node version: v18.17.1
  • Operating system: debian
@Apollon77
Copy link
Contributor

This happens because JavaScript adapter is installing additional npm modules. During this such error scould happen because npm analyzes your complete npm tree (so from all adapters!)
SO the JavaScriopt adapter can not prevent these errors alone. And in fact deprecations do not mean that a module is bad, just that it is no longer actively maintained.

because of the fact that javascript adapter do not know if npm putput is informational or error it logs that as error. We could log it differently, but that would be all we can do.

Where is the problem for you to have these logs when the adapter starts?

@Eistee82
Copy link
Author

I think the adapter should make it clear that the following messages are about installations of different adapters. If possible, it would be helpful to show which adapter uses these deprecated modules.

Just as an idea: maybe someone could create some kind of maintenance page elsewhere in iobroker:

  • Adapter xy123: There are 3 new versions with the following changes... (braking changes highlighted)
  • Adapter xy234: has not been updated for 2 years
  • Adapter xy345: reports the following problems (deprecated modules)
  • Adapter xy456: Is not in the repository or installed manually
  • Adapter xy567: Was removed from the repository because....

@Apollon77
Copy link
Contributor

The problem is that nom validates the "whole tree" (whetever this means in a certain situation, esoecially with installing sub modules in javascript folder), so noone knoens (beside npm) where an warning7error comes from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants