Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General tidy-up work #21

Open
csswizardry opened this issue Jun 28, 2016 · 2 comments
Open

General tidy-up work #21

csswizardry opened this issue Jun 28, 2016 · 2 comments
Labels
enhancement

Comments

@csswizardry
Copy link
Member

csswizardry commented Jun 28, 2016 •
edited by csshugs

Opening a long-running issue just to have somewhere to commit typos, syntax-tidying, etc. against 👍
csswizardry added a commit that referenced this issue Jun 28, 2016
@csswizardry
[refs #21] Correctly stringify Sass
08ae652
csswizardry added a commit that referenced this issue Jun 28, 2016
@csswizardry
[refs #21] Provide better wording around default font settings
988329c
csswizardry added a commit that referenced this issue Jun 28, 2016
@csswizardry
[refs #21] Add button style variants
c65bae8
csswizardry added a commit that referenced this issue Jul 2, 2016
@csswizardry
[refs #21] Tidy up formatting a little
81f70e1
csswizardry added a commit that referenced this issue Jul 6, 2016
@csswizardry
[refs #21] Tidy up settings’ spacing
8396369
csswizardry added a commit that referenced this issue Jul 6, 2016
@csswizardry
[refs #21] Tidy up generic spacing
0f201b1
csswizardry added a commit that referenced this issue Jul 6, 2016
@csswizardry
[refs #21] Tidy up elements’ spacing
02ea096
csswizardry added a commit that referenced this issue Jul 6, 2016
@csswizardry
[refs #21] Tidy up objects’ spacing
00e7321
csswizardry added a commit that referenced this issue Jul 6, 2016
@csswizardry
[refs #21] Tidy up utils’ spacing
1a23d60
csswizardry added a commit that referenced this issue Jul 6, 2016
@csswizardry
[refs #21] Add new button styles
db239b0
csswizardry added a commit that referenced this issue Jul 15, 2016
@csswizardry
[refs #21 #54] More consistent error formatting
d4e89b4
@csswizardry csswizardry mentioned this issue Jul 19, 2016
Merged
@anselmh anselmh mentioned this issue Jul 19, 2016
Closed
csswizardry pushed a commit that referenced this issue Jul 22, 2016
@anselmh @csswizardry
[refs #21] Remove IE7 specific code, since we don’t support IE7.
a1613ef
csswizardry added a commit to csswizardry/inuitcss that referenced this issue Jul 22, 2016
@csswizardry
[refs inuitcss#21] Test
ca43309
csshugs pushed a commit that referenced this issue Jul 22, 2016
[refs #21] Pluralize word correctly
5920572
csshugs pushed a commit that referenced this issue Jul 22, 2016
[refs #21] Correct config function name in comments
3c40409 
The actual function name changed from `config` to `inuit-config`
some time ago. In the comments documentation, it was still revealed
as `config`.
csshugs pushed a commit that referenced this issue Jul 22, 2016
[refs #21] Remove second warning of not altering vars
28ddf3d 
There is already a big warning banner above this block of
variables that says not to alter anything below, which made
this sentence redundant.
csswizardry added a commit that referenced this issue Jul 22, 2016
@csswizardry
[refs #21] Tidy up formatting in functions file
6692f25
csshugs pushed a commit that referenced this issue Jul 22, 2016
[refs #21] Fix weird title case incidents
6fc06e6 
As A German Person, I'm Really Not Sure For 100%, But Always
Thought That Literally Everything In The English Language Is
Written In Lower Case.
csshugs pushed a commit that referenced this issue Jul 22, 2016
[refs #21] Add missing word
2fea0ee
csshugs pushed a commit that referenced this issue Jul 22, 2016
[refs #21] Reverse (correct) meaning of sentence
42fa136
csshugs pushed a commit that referenced this issue Jul 22, 2016
[refs #21] Widths classes format changed
6250122 
There is no spoken word format for width classes anymore, so
advertising them in the comments makes no sense.
csshugs pushed a commit that referenced this issue Jul 22, 2016
[refs #21] Remove accidental existing line
fb1a958
csswizardry added a commit that referenced this issue Jul 25, 2016
@csswizardry
[refs #21] Show example of how to rename Sass MQ breakpoints
7600ebc
@csshugs csshugs mentioned this issue Jul 28, 2016
Closed
@florianbouvot
Copy link
Member

florianbouvot commented Jul 29, 2016 •
edited

I wonder if comments needs end point:

like this

/* Size variants.
   ========================================================================== */

or

/* Size variants
   ========================================================================== */

?

florianbouvot pushed a commit that referenced this issue Jul 29, 2016
[refs #21] Tidy up objects.block spacing
9570a4e
florianbouvot pushed a commit that referenced this issue Jul 29, 2016
[refs #21] Tidy up utilities.widths spacing
fbc4fa1
@florianbouvot
Copy link
Member

What about to order size variants in the same order?

  • objects.block and objects.box order: flush / tiny / small / large / huge
  • objects.layout, objects.media and objects.flag order: tiny / small / large / huge / flush

csshugs pushed a commit that referenced this issue Aug 2, 2016
[refs #21] Add missing trailing semicolon
ba137e8
@csshugs csshugs mentioned this issue Aug 30, 2016
Merged
csshugs pushed a commit that referenced this issue Sep 2, 2016
[refs #21] Remove now needless warning
0a528df
csshugs pushed a commit that referenced this issue Dec 28, 2016
[refs #21] Fix typo
c8138d8
csshugs pushed a commit that referenced this issue Dec 29, 2016
[refs #21] Fix wrong partial name
c57848e
anselmh added a commit that referenced this issue Mar 22, 2017
@anselmh
[refs #21] Consistent order for size variants.
803f452 
As per #21 (comment),
we want to define our size variants in the various objects
consistently.
@anselmh anselmh mentioned this issue Mar 22, 2017
Merged
anselmh added a commit that referenced this issue Mar 22, 2017
@anselmh
Merge pull request #283 from inuitcss/tkt-0021-3
7e339a2 
[refs #21] Consistent order for size variants.
csshugs pushed a commit that referenced this issue May 5, 2017
[refs #21] Make quotes compliant with code-convention
7edd453
csshugs pushed a commit that referenced this issue May 5, 2017
[refs #21] Add correct apostrophe
8822d32
This was referenced Dec 8, 2017
Closed
Merged
csshugs pushed a commit that referenced this issue Jan 10, 2018
[refs #21] Update copyright
29ec23c
This was referenced Jan 21, 2018
Closed
Merged
csshugs pushed a commit that referenced this issue Feb 26, 2018
[refs #21] Remove useless linting exceptions
e7e1122
csshugs pushed a commit that referenced this issue Feb 26, 2018
[refs #21] Fix widths unit-test
e3f0e28 
We are using True to unit-test our mixins and functions. True
used to refuse to test selector outputs, so we commented out
that test. Seems like, it supports this feature now.
csshugs pushed a commit that referenced this issue Feb 26, 2018
[refs #21] Remove useless linting exception
d81666f
csshugs pushed a commit that referenced this issue Feb 26, 2018
[refs #21] Align whitespace
c15db07
Jamiewarb added a commit to Jamiewarb/inuitcss that referenced this issue Mar 5, 2018
@Jamiewarb
[refs inuitcss#21] Fix minor typo in example.main.scss file
f337d9d 
`bloat your CSS, depending of the amount`

This should read "depending on", rather than "depending of"
Jamiewarb added a commit to Jamiewarb/inuitcss that referenced this issue Mar 5, 2018
@Jamiewarb
[refs inuitcss#21] Fix minor typo in example.main.scss file
0eb01c7 
`bloat your CSS, depending of the amount`

This should read "depending on", rather than "depending of"
csshugs added a commit that referenced this issue Mar 5, 2018
@csshugs
Merge pull request #359 from Jamiewarb/tkt-0021
7284ae4 
[refs #21] Fix minor typo in example.main.scss file
csshugs pushed a commit that referenced this issue Jan 8, 2019
[refs #21] Update year in copyright notice
eec9bcb
fspin pushed a commit to fspin/inuitcss that referenced this issue Jan 21, 2019
Merge remote-tracking branch 'upstream/develop' into develop
946e302 
* upstream/develop:
  [refs inuitcss#21] Update year in copyright notice
csshugs added a commit that referenced this issue Apr 8, 2020
@csshugs
[refs #21] Update year in copyright notice
b6e2ace
@inuitcss inuitcss locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@csswizardry @florianbouvot