Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation groups are (wrongly) translated during selection #398

Closed
eric-intuitem opened this issue May 8, 2024 · 1 comment · Fixed by #411
Closed

Implementation groups are (wrongly) translated during selection #398

eric-intuitem opened this issue May 8, 2024 · 1 comment · Fixed by #411
Assignees
Labels
bug Something isn't working

Comments

@eric-intuitem
Copy link
Collaborator

Describe the bug
When using French language, and selecting an implementation group for e.g. Fedramp, some IGs are wrongly translated:
Low -> Faible
Moderate is not translated
High -> Haut

To Reproduce
Use Fedramp with French interface

Expected behavior
No translation at all.

@ab-smith ab-smith added the bug Something isn't working label May 9, 2024
@ab-smith
Copy link
Contributor

ab-smith commented May 11, 2024

the model is sending the right labels, for some reason, it's the component that is translating the strings while it should just render them,
image

And indeed:
image

I see where this logic could be useful, but it's not deterministic, we shall at least have an explicit flag on the AutoCompleteSelect component to do so; I'm adding a translateOptions param to the component with default value to true to make a smooth transition.

@ab-smith ab-smith self-assigned this May 11, 2024
@ab-smith ab-smith linked a pull request May 11, 2024 that will close this issue
ab-smith added a commit that referenced this issue May 12, 2024
#398 Fix unwanted translation on AutoCompleteSelect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants