Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement slight pause on engine stop #103

Open
qdot opened this issue Oct 26, 2023 · 0 comments
Open

Implement slight pause on engine stop #103

qdot opened this issue Oct 26, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@qdot
Copy link
Contributor

qdot commented Oct 26, 2023

Via sentry, we've seen instances of users hammering the start/stop engine button while crash loops are happening. Apparently we can send engine stopped events before all of the native tasks have cleared out, which causes some really weird errors. Put in a slight delay after a crash happens or engine is stopped (like 500ms) to give the native runtime some room to clean up for now. This can be removed once we have a guarantee in place that we'll have finished out all native tasks before sending the engine stopped message.

@qdot qdot added the enhancement New feature or request label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant