New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

heap-buffer-overflow while packing weight #167

Open

yufenglee opened this issue Mar 13, 2024 · 1 comment

Assignees

Labels

bug

yufenglee commented Mar 13, 2024

N * blks can be odd. There is no need to iterate by 2 and scales[i + 1] / 16 causes heap-buffer-overflow:

neural-speed/bestla/bestla/bestla_prologue_b.h

Line 460 in bc5ee16

tmpscales[i] = scales[i] / 16;

luoyu-intel added the bug label

luoyu-intel self-assigned this

Contributor

luoyu-intel commented Mar 15, 2024

Thanks! We're looking into this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment