Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[E2E] Basic/kernel_info.cpp and GroupAlgorithm/root_group.cpp XPASS'd on OCL CPU in SYCL Nightly #13735

Closed
uditagarwal97 opened this issue May 10, 2024 · 6 comments · Fixed by #13749
Closed

[E2E] Basic/kernel_info.cpp and GroupAlgorithm/root_group.cpp XPASS'd on OCL CPU in SYCL Nightly #13735

uditagarwal97 opened this issue May 10, 2024 · 6 comments · Fixed by #13749
Assignees
@sarnex
Labels
bug Something isn't working

Comments

@uditagarwal97
Copy link
Contributor

Describe the bug

Run: https://github.com/intel/llvm/actions/runs/9019645870/job/24786062097

024-05-09T17:42:25.8702355Z XPASS: SYCL :: Basic/kernel_info.cpp (274 of 2025)
2024-05-09T17:42:25.8702739Z ******************** TEST 'SYCL :: Basic/kernel_info.cpp' FAILED ********************
2024-05-09T17:42:25.8702998Z Exit Code: 0
2024-05-09T17:42:25.8703080Z 
2024-05-09T17:42:25.8703144Z Command Output (stdout):
2024-05-09T17:42:25.8703305Z --
2024-05-09T17:42:25.8703422Z # RUN: at line 1
2024-05-09T17:42:25.8704031Z /__w/llvm/llvm/toolchain/bin//clang++   -fsycl -fsycl-targets=spir64  /__w/llvm/llvm/llvm/sycl/test-e2e/Basic/kernel_info.cpp -o /__w/llvm/llvm/build-e2e/Basic/Output/kernel_info.cpp.tmp.out
2024-05-09T17:42:25.8705068Z # executed command: /__w/llvm/llvm/toolchain/bin//clang++ -fsycl -fsycl-targets=spir64 /__w/llvm/llvm/llvm/sycl/test-e2e/Basic/kernel_info.cpp -o /__w/llvm/llvm/build-e2e/Basic/Output/kernel_info.cpp.tmp.out
2024-05-09T17:42:25.8705683Z # note: command had no output on stdout or stderr
2024-05-09T17:42:25.8705895Z # RUN: at line 2
2024-05-09T17:42:25.8706376Z env ONEAPI_DEVICE_SELECTOR=opencl:cpu  /__w/llvm/llvm/build-e2e/Basic/Output/kernel_info.cpp.tmp.out
2024-05-09T17:42:25.8706940Z # executed command: env ONEAPI_DEVICE_SELECTOR=opencl:cpu /__w/llvm/llvm/build-e2e/Basic/Output/kernel_info.cpp.tmp.out
2024-05-09T17:42:25.8707335Z # note: command had no output on stdout or stderr
2024-05-09T17:42:25.8707493Z 
2024-05-09T17:42:25.8707553Z --
2024-05-09T17:42:25.8707618Z 
2024-05-09T17:42:25.8707667Z ********************
2024-05-09T17:42:25.8707877Z XPASS: SYCL :: GroupAlgorithm/root_group.cpp (1177 of 2025)
2024-05-09T17:42:25.8712295Z ******************** TEST 'SYCL :: GroupAlgorithm/root_group.cpp' FAILED ********************
2024-05-09T17:42:25.8712641Z Exit Code: 0
2024-05-09T17:42:25.8712755Z 
2024-05-09T17:42:25.8712817Z Command Output (stdout):
2024-05-09T17:42:25.8712987Z --
2024-05-09T17:42:25.8713119Z # RUN: at line 3
2024-05-09T17:42:25.8713802Z /__w/llvm/llvm/toolchain/bin//clang++   -fsycl -fsycl-targets=spir64  /__w/llvm/llvm/llvm/sycl/test-e2e/GroupAlgorithm/root_group.cpp -I . -o /__w/llvm/llvm/build-e2e/GroupAlgorithm/Output/root_group.cpp.tmp.out
2024-05-09T17:42:25.8714971Z # executed command: /__w/llvm/llvm/toolchain/bin//clang++ -fsycl -fsycl-targets=spir64 /__w/llvm/llvm/llvm/sycl/test-e2e/GroupAlgorithm/root_group.cpp -I . -o /__w/llvm/llvm/build-e2e/GroupAlgorithm/Output/root_group.cpp.tmp.out
2024-05-09T17:42:25.8715788Z # note: command had no output on stdout or stderr
2024-05-09T17:42:25.8716028Z # RUN: at line 4
2024-05-09T17:42:25.8716468Z env ONEAPI_DEVICE_SELECTOR=opencl:cpu  /__w/llvm/llvm/build-e2e/GroupAlgorithm/Output/root_group.cpp.tmp.out
2024-05-09T17:42:25.8717092Z # executed command: env ONEAPI_DEVICE_SELECTOR=opencl:cpu /__w/llvm/llvm/build-e2e/GroupAlgorithm/Output/root_group.cpp.tmp.out
2024-05-09T17:42:25.8717520Z # note: command had no output on stdout or stderr

To reproduce

DPC++ commit: 4b9819f

Environment

Backend and Device: OpenCL CPU

Additional context

No response
@uditagarwal97 uditagarwal97 added the bug Something isn't working label May 10, 2024
@uditagarwal97
Copy link
Contributor Author

@sarnex @JackAKirk FYI.

@JackAKirk
Copy link
Contributor

It might just be a coincidence that this is a amd cpu, but for 22.04 amd also requires gcc12 for rocm: ROCm/ROCm#2949.
In any case the timing suggests it was caused by the uplift to build with gcc12: #13619

@sarnex
Copy link
Contributor

sarnex commented May 10, 2024

Thanks, I'll fix this.

@sarnex sarnex mentioned this issue May 10, 2024
Merged
@sarnex sarnex self-assigned this May 10, 2024
@sarnex
Copy link
Contributor

sarnex commented May 10, 2024

@JackAKirk Assigning to you for now, if it still fails after reverting gcc12 please assign back to me.

@sarnex sarnex assigned JackAKirk and unassigned sarnex May 10, 2024
@JackAKirk JackAKirk mentioned this issue May 10, 2024
Merged
aelovikov-intel pushed a commit that referenced this issue May 10, 2024
@JackAKirk
[CI][HIP] Install libstdc++-12-dev without gcc12. (#13752)
b155c18 
This partially reverts the changes made in
#13619 to use libstdc++-12-dev without
gcc12.
This also seems to work fine to build dpc++ within the docker. But
should come without the CI failures that might have been induced by the
gcc uplift:
- #13736
- #13735
If the above issues were not caused by the gcc version uplift, then this
patch should also reveal that.

Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
@JackAKirk JackAKirk assigned sarnex and unassigned JackAKirk May 13, 2024
@JackAKirk
Copy link
Contributor

@JackAKirk Assigning to you for now, if it still fails after reverting gcc12 please assign back to me.

@sarnex I've signed it back to you. Everything is now working except the Xpasses so I think it is safe to merge your PR.

@JackAKirk JackAKirk mentioned this issue May 13, 2024
Merged
@sarnex
Copy link
Contributor

sarnex commented May 13, 2024

Got it, thx

sarnex added a commit that referenced this issue May 13, 2024
@sarnex
[SYCL][E2E] Fix two XPASSes on OCL CPU (#13749)
b758dda 
They are passing on CPU in the nightlies.

Closes: #13735

---------

Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
aelovikov-intel pushed a commit that referenced this issue May 14, 2024
@JackAKirk
[CI] Switch docker image back to "latest". (#13766)
add7dab 
This PR reverts back to latest docker image from changes made in
- #13618
- #13606

#13752 fixed
#13736 and
#13735 was fixed by
#13771
This means we can now use this "latest" docker image in the main CI
testing.

Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarnex sarnex

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SYCL][E2E] Fix two XPASSes on OCL CPU sarnex/llvm
3 participants
@sarnex @uditagarwal97 @JackAKirk