Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propose to add a new folder called ref_apps #137

Closed
xuechendi opened this issue Mar 11, 2024 · 4 comments
Closed

propose to add a new folder called ref_apps #137

xuechendi opened this issue Mar 11, 2024 · 4 comments

Comments

@xuechendi
Copy link
Contributor

Purpose:

  • provides more examples and not add unnecessary codes to webui.
  • easily add/remove, seperate ref apps case by case
  • as temporary store, upstream to Intel's genAI example repo in future.
@xuechendi
Copy link
Contributor Author

@carsonwang , propose to add a new folder for rec apps

@xuechendi
Copy link
Contributor Author

This is where I put my current ref_apps:
https://github.com/xuechendi/langchain-chatbot/tree/llm-on-ray-apps

@xwu99
Copy link
Contributor

xwu99 commented Mar 13, 2024

@xuechendi could we call them "demo" or "samples" rather than ref_apps ? sample apps are more fully functional than example apps.

@xwu99
Copy link
Contributor

xwu99 commented May 15, 2024

Already added llm-on-ray/application, but I think it's better to names applications and move current one into a subdir.

@xwu99 xwu99 closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants