Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mono_chrome to VAEncSequenceParameterBufferAV1 #691

Open
rosetta-jpn opened this issue Feb 27, 2023 · 4 comments
Open

Add mono_chrome to VAEncSequenceParameterBufferAV1 #691

rosetta-jpn opened this issue Feb 27, 2023 · 4 comments

Comments

@rosetta-jpn
Copy link

To chroma subsampling completely, it is required to set mono_chrome.
See https://aomediacodec.github.io/av1-spec/#color-config-semantics

In fact, VADecPictureParameterBufferAV1 has mono_chrome variable, but VAEncSequenceParameterBufferAV1 doesn't have.
It is necessary to add mono_chrome to VAEncSequenceParameterBufferAV1.

@rosetta-jpn
Copy link
Author

Friendly ping?

@XinfengZhang
Copy link
Contributor

@rosetta-jpn because current intel implementation does not support it, but indeed , maybe need add it for common usage, do you know which vender are using it? will you file an PR to add it?

@rosetta-jpn
Copy link
Author

I think no vendor supports mono_chrome today. It should be there for completeness.
I will add it.

@rosetta-jpn
Copy link
Author

Created pull request #697

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants