Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINT]: issue_label doesn't work for Organizations #1840

Open
1 task done
ikegentz opened this issue Aug 15, 2023 · 4 comments · May be fixed by #2052
Open
1 task done

[MAINT]: issue_label doesn't work for Organizations #1840

ikegentz opened this issue Aug 15, 2023 · 4 comments · May be fixed by #2052
Labels
hacktoberfest Issues for participation in Hacktoberfest Status: Up for grabs Issues that are ready to be worked on by anyone Type: Bug Something isn't working as documented

Comments

@ikegentz
Copy link

Describe the need

There is currently no way to create an issue_label for a repo owned by an organization, rather than the account on which the PAT is used for authentication in the provider.

Specifically, the repository attribute in the github_issue_label resource is hard-coded to this format: https://api.github.com/repos/<PAT user>/, meaning if you try to pass <my organization>/<repo>, you'll end up with https://api.github.com/repos/<PAT user>/<my organization>/<repo>.

The API already supports an owner argument, so it seems like that could be exposed in the resource so that this would work.

SDK Version

No response

API Version

No response

Relevant log output

│ Error: POST https://api.github.com/repos/<PAT user>/<my org>/<repo>/labels: 404 Not Found []

Code of Conduct

  • I agree to follow this project's Code of Conduct
@ikegentz ikegentz added Status: Triage This is being looked at and prioritized Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR labels Aug 15, 2023
@nickfloyd nickfloyd added Status: Up for grabs Issues that are ready to be worked on by anyone and removed Status: Triage This is being looked at and prioritized labels Aug 18, 2023
@kfcampbell kfcampbell added Type: Bug Something isn't working as documented and removed Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR labels Aug 24, 2023
@kfcampbell
Copy link
Member

Great catch! Do you have the interest/inclination to open up a PR to fix this behavior?

@ikegentz
Copy link
Author

ikegentz commented Sep 6, 2023

Great catch! Do you have the interest/inclination to open up a PR to fix this behavior?

Yes, I'd be happy to open a PR for this. May need a little guidance for getting started, but I should be able to get to this in a couple of weeks.

@kfcampbell
Copy link
Member

Awesome! Our CONTRIBUTING.md, especially this section about how to build the provider so it's invoked in your local Terraform runs. For full debugging, this section is the one to read.

@nickfloyd nickfloyd added the hacktoberfest Issues for participation in Hacktoberfest label Sep 21, 2023
@ikegentz ikegentz linked a pull request Dec 9, 2023 that will close this issue
Open
4 tasks
@ikegentz
Copy link
Author

ikegentz commented Dec 9, 2023

Apologies for the delay in getting this, but I've got a PR up that should address this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest Issues for participation in Hacktoberfest Status: Up for grabs Issues that are ready to be worked on by anyone Type: Bug Something isn't working as documented
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Org Option to issue_label ikegentz/terraform-provider-github
3 participants
@nickfloyd @kfcampbell @ikegentz