Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cropper Options #8

Open
oyeanuj opened this issue Nov 23, 2016 · 3 comments
Open

Cropper Options #8

oyeanuj opened this issue Nov 23, 2016 · 3 comments

Comments

@oyeanuj
Copy link

oyeanuj commented Nov 23, 2016

Hi @aaronshaf ! Thank you for open sourcing this useful library. Wondering if there are configuration options for the following -

  1. Have a circular cropper instead of square or rectangle?
  2. Have the cropper centered on the image when initialized?

Thanks!

@shichongrui
Copy link

There are not currently. But we are open to pull requests adding said configuration options.

@oyeanuj
Copy link
Author

oyeanuj commented Nov 29, 2016

@shichongrui Thanks for the response! Any guidance on how to approach adding the two since you know the code and the domain best?

@shichongrui
Copy link

So from what I can see the cropper is already centered on the image when initialized. So perhaps what you are looking for is more than just centering the cropper on the image?

The circular issue. That wouldn't be as easy. The cropper is currently built completely around moving and resizing a rectangle/square. A few questions arise such as how do you resize the circle/oval? I would almost say that it may warrant just forking this repository and using it as a base for creating your own circular cropping component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants